Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): create framework subdirectory for web components #303

Merged
merged 33 commits into from
Nov 15, 2024

Conversation

kennylam
Copy link
Member

This moves current web component packages to their own subdirectory packages/web-components, allowing for other frameworks to exist in the project (like React).

Changelog

Changed

  • move all web component packages to packages/web-components
  • update dependencies and build tasks to reflect changes

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for carbon-labs ready!

Name Link
🔨 Latest commit f3ffd2e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs/deploys/67376b1481e9430008f476f8
😎 Deploy Preview https://deploy-preview-303--carbon-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennylam kennylam closed this Nov 13, 2024
@kennylam kennylam reopened this Nov 13, 2024
@kennylam kennylam closed this Nov 13, 2024
@kennylam kennylam reopened this Nov 13, 2024
@kennylam kennylam closed this Nov 13, 2024
@kennylam kennylam reopened this Nov 13, 2024
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! LGTM!

@annawen1 annawen1 merged commit 9d1bfa6 into carbon-design-system:main Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants